Use new Localization and Downloader implementations from extractor #2713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauriciocolli
force-pushed
the
compatibility-extractor
branch
from
bc4750c to
540d63f
Compare
TobiGr
reviewed
Nov 1, 2019
| }); | ||
|
|
||
| Preference setPreferredLanguage = findPreference(getString(R.string.content_language_key)); | ||
| /*Preference setPreferredLanguage = findPreference(getString(R.string.content_language_key)); |
Contributor
There was a problem hiding this comment.
Can you please add a comment that this is not needed due to the changes below?
TobiGr
reviewed
Nov 1, 2019
Contributor
TobiGr
left a comment
TobiGr
left a comment
There was a problem hiding this comment.
The list of content countries is now displayed in English. Is this the intended behavior? Before your changes we used the countries' names in their own language.
mauriciocolli
force-pushed
the
compatibility-extractor
branch
from
540d63f to
4c02214
Compare
Contributor
Author
|
@TobiGr are you sure? This is how the file looks like as of the last commit. It seems that currently only the language names are done that way. |
Contributor
|
My bad, I mixed content language and country during my review. |
TobiGr
previously approved these changes
Nov 16, 2019
Contributor
TobiGr
left a comment
TobiGr
left a comment
There was a problem hiding this comment.
@mauriciocolli Can you rebase and update the extractor version? It's good to go.
Before, the direct value was given to the user, now it uses the parsed date so we can match the device's language. To get the relative time from the parsed dates, we use the PrettyTime library. Also introduces a debug option to check the service's original value.
mauriciocolli
force-pushed
the
compatibility-extractor
branch
from
4c02214 to
b125ff7
Compare
Contributor
Author
|
@TobiGr Done. |
TobiGr
approved these changes
Nov 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on TeamNewPipe/NewPipeExtractor#158.